> -----Original Message----- > From: Ankit Kumar [mailto:ankit.kumar@xxxxxxxxxxx] > Sent: Thursday, May 26, 2022 10:48 AM > To: axboe@xxxxxxxxx > Cc: fio@xxxxxxxxxxxxxxx; krish.reddy@xxxxxxxxxxx; > joshi.k@xxxxxxxxxxx; anuj20.g@xxxxxxxxxxx; Ankit Kumar > <ankit.kumar@xxxxxxxxxxx> > Subject: [PATCH v2 6/8] zbd: Check for direct flag only if its block device > > nvme-ns generic character devices currently do not support O_DIRECT > flag. > Check for fio option for direct flag only if filetype is a block device. > > t/zbd skip test case #1 for character devices as don't require > direct I/O. > > Signed-off-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx> > --- I tested this with a zoned scsi_debug device created by: modprobe scsi_debug zbc=2 I observed that running t/zbd/test-zbd-support -t 1 -l /dev/sg2 on v1 of this patch series produced a test failure whereas on v2 of this patch series the test case is appropriately skipped. Tested-by: Vincent Fu <vincent.fu@xxxxxxxxxxx>
