> -----Original Message----- > From: Ankit Kumar [mailto:ankit.kumar@xxxxxxxxxxx] > + > + if (io_u->ddir == DDIR_READ) > + cmd->opcode = nvme_cmd_read; > + if (io_u->ddir == DDIR_WRITE) > + cmd->opcode = nvme_cmd_write; Consider changing this to a switch statement and adding a default: case in case someone tries to send an unsupported command. Since this is in the fast path a switch statement would also reduce the number of times ddir is checked.
