On May 23, 2022 / 18:40, Ankit Kumar wrote: > nvme-ns generic character devices currently do not support > O_DIRECT flag. Check for fio option direct flag only if > filetype is a block device. > > Signed-off-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx> Hi Ankit, This change skips the direct option check not only for the nvme-ns generic character devices but also SCSI generic character devices. And it triggers failure of the test case #1 in t/zbd/test-zbd-support script. The failure happens when the script is run for a SCSI generic device with libzbc I/O engine (-l option). The test case confirms that direct=0 reports an error, but test test will not be required after applying this patch. Could you care to fix the test case to skip for character devices? -- Best Regards, Shin'ichiro Kawasaki
