On 4/28/22 6:47 PM, Ammar Faizi wrote: > From: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> > > Avoid a NULL pointer dereference bug. There are many places that don't > handle the ENOMEM case. Add it. > > Signed-off-by: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> > --- > client.c | 107 +++++++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 89 insertions(+), 18 deletions(-) > > @@ -473,6 +478,8 @@ int fio_client_add(struct client_ops *ops, const char *hostname, void **cookie) > } > > client = get_new_client(); > + if (!client) > + return -ENOMEM; I don't think we should be using -errno in fio if we can avoid it. Are there cases where we need to discern one failure from another for alloc fixes? Looking at this case, we really just want a non-zero return. -- Jens Axboe
