On 4/28/22 6:46 PM, Ammar Faizi wrote: > From: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> > > Hi Jens, > > This series contains patches that were dropped from my previous thread: > > https://lore.kernel.org/fio/20220428203954.222165-1-ammarfaizi2@xxxxxxxxxxx > > Plus, I have more patches in this series. This series contains error > handling fixes, mostly about ENOMEM. There are 8 patches in this > series. All of them are ENOMEM handling stuff except that patch #4 has > extra fixes and a bit of refactoring. While I agree on good error handling in general, I'm a bit dubious at malloc() related NULL returns. Have you ever seen malloc() return NULL? On Linux, or somewhere else? Most systems overcommit themselves to death, and things will death spiral before you ever get NULL. I'm happy to be convinced otherwise, just naturally skeptical that there's any real value in making changes like this. -- Jens Axboe
