> -----Original Message----- > From: Ammar Faizi [mailto:ammarfaizi2@xxxxxxxxxxx] > Sent: Thursday, April 28, 2022 8:47 PM > To: Jens Axboe <axboe@xxxxxxxxx> > Cc: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx>; Alviro Iskandar Setiawan > <alviro.iskandar@xxxxxxxxxxx>; Niklas Cassel > <Niklas.Cassel@xxxxxxx>; fio Mailing List <fio@xxxxxxxxxxxxxxx>; > GNU/Weeb Mailing List <gwml@xxxxxxxxxxxxxxxx> > Subject: [PATCH v1 1/8] cgroup: Add ENOMEM handling on a `malloc()` > call > > From: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> > > Avoid a NULL pointer dereference bug when `ENOMEM`. > > Signed-off-by: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> Looks good. Reviewed-by: Vincent Fu <vincent.fu@xxxxxxxxxxx> > --- > cgroup.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/cgroup.c b/cgroup.c > index 77e31a4d..b559b70f 100644 > --- a/cgroup.c > +++ b/cgroup.c > @@ -114,6 +114,8 @@ void cgroup_kill(struct flist_head *clist) > static char *get_cgroup_root(struct thread_data *td, struct cgroup_mnt > *mnt) > { > char *str = malloc(64); > + if (!str) > + return NULL; > > if (td->o.cgroup) > sprintf(str, "%s/%s", mnt->path, td->o.cgroup); > @@ -178,6 +180,8 @@ int cgroup_setup(struct thread_data *td, struct > flist_head *clist, struct cgroup > * Create container, if it doesn't exist > */ > root = get_cgroup_root(td, *mnt); > + if (!root) > + return 1; > if (mkdir(root, 0755) < 0) { > int __e = errno; > > -- > Ammar Faizi
