On 4/6/22 11:05 AM, Mohamad Gebai wrote: > This set of patches introduces version 3 of the iolog replay. This > version adds support for timestamps on both iolog_read and iolog_write. > The 'wait' action is no longer supported with version 3, as the same > behavior can be achieved with timestamps, and it keeps the iolog file > easier to follow. This could also allow to potentially deprecate the > 'wait' action eventially. Change looks good to me, but it would be nice with some actual commit messages. #1 has one, but it's formatted pretty strange. 2 and 3 don't have any. At the very least, there should be a basic description of "why" the change is made in the commit message. Can you send a v2 with proper commit messages, and #1 formatted that isn't a strange list? Thanks! -- Jens Axboe
