On 1/16/22 5:45 PM, Damien Le Moal wrote: >> +static struct thread_stat *gen_mixed_ddir_stats_from_ts(struct thread_stat *ts) >> +{ >> + struct thread_stat *ts_lcl; >> + >> + /* >> + * Handle aggregation of Reads (ddir = 0), Writes (ddir = 1), and >> + * Trims (ddir = 2) >> + */ >> + ts_lcl = malloc(sizeof(struct thread_stat)); > > No failed allocation check ? For better or worse, fio generally just happily ignores allocation failures... That doesn't mean that we should not move towards making that better, particularly for new additions and where it's easy to handle it. -- Jens Axboe