From: Niklas Cassel <niklas.cassel@xxxxxxx> add_lat_percentile_sample_noprio() is the regular function to add a latency percentile sample. It adds a regular sample (it doesn't add any per priority sample). Therefore, it makes sense that this function has no suffix, neither _noprio nor _prio. Drop the _noprio suffix from add_lat_percentile_sample_noprio(), to make it more obvious that this function should be used if you want to add a regular percentile sample. Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx> Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> --- stat.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/stat.c b/stat.c index 1e0da99d..28e49a89 100644 --- a/stat.c +++ b/stat.c @@ -3052,8 +3052,9 @@ void add_sync_clat_sample(struct thread_stat *ts, unsigned long long nsec) add_stat_sample(&ts->sync_stat, nsec); } -static void add_lat_percentile_sample_noprio(struct thread_stat *ts, - unsigned long long nsec, enum fio_ddir ddir, enum fio_lat lat) +static void add_lat_percentile_sample(struct thread_stat *ts, + unsigned long long nsec, + enum fio_ddir ddir, enum fio_lat lat) { unsigned int idx = plat_val_to_idx(nsec); assert(idx < FIO_IO_U_PLAT_NR); @@ -3068,7 +3069,7 @@ static void add_lat_percentile_prio_sample(struct thread_stat *ts, { unsigned int idx = plat_val_to_idx(nsec); - add_lat_percentile_sample_noprio(ts, nsec, ddir, lat); + add_lat_percentile_sample(ts, nsec, ddir, lat); if (!high_prio) ts->io_u_plat_low_prio[ddir][idx]++; @@ -3117,7 +3118,7 @@ void add_clat_sample(struct thread_data *td, enum fio_ddir ddir, * the prio lat percentile sample when lat_percentiles=1. */ if (ts->lat_percentiles) - add_lat_percentile_sample_noprio(ts, nsec, ddir, FIO_CLAT); + add_lat_percentile_sample(ts, nsec, ddir, FIO_CLAT); else add_lat_percentile_prio_sample(ts, nsec, ddir, high_prio, FIO_CLAT); @@ -3185,7 +3186,7 @@ void add_slat_sample(struct thread_data *td, enum fio_ddir ddir, offset, ioprio); if (ts->slat_percentiles) - add_lat_percentile_sample_noprio(ts, nsec, ddir, FIO_SLAT); + add_lat_percentile_sample(ts, nsec, ddir, FIO_SLAT); if (needs_lock) __td_io_u_unlock(td); -- 2.33.1