On 2021/11/09 9:28, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@xxxxxxx>
>
> Commit 1437d6357429 ("libaio,io_uring: relax cmdprio_percentage
> constraints") relaxed the cmdprio_percentage constraints such that
> cmdprio_percentage and prioclass/prio could be used together.
>
> However, it forgot to remove the mention of this constraint from
> the docs. Update the docs to reflect the new behavior.
>
> Fixes: 1437d6357429 ("libaio,io_uring: relax cmdprio_percentage constraints")
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
> ---
> HOWTO | 5 ++---
> fio.1 | 3 +--
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/HOWTO b/HOWTO
> index 297a0485..196bca6c 100644
> --- a/HOWTO
> +++ b/HOWTO
> @@ -2167,9 +2167,8 @@ with the caveat that when used on the command line, they must come after the
>
> Set the percentage of I/O that will be issued with the highest priority.
> Default: 0. A single value applies to reads and writes. Comma-separated
> - values may be specified for reads and writes. This option cannot be used
> - with the :option:`prio` or :option:`prioclass` options. For this option
> - to be effective, NCQ priority must be supported and enabled, and `direct=1'
> + values may be specified for reads and writes. For this option to be
> + effective, NCQ priority must be supported and enabled, and `direct=1'
> option must be used. fio must also be run as the root user.
>
> .. option:: cmdprio_class=int[,int] : [io_uring] [libaio]
> diff --git a/fio.1 b/fio.1
> index 78988c9e..e3c3feae 100644
> --- a/fio.1
> +++ b/fio.1
> @@ -1965,8 +1965,7 @@ with the caveat that when used on the command line, they must come after the
> .BI (io_uring,libaio)cmdprio_percentage \fR=\fPint[,int]
> Set the percentage of I/O that will be issued with the highest priority.
> Default: 0. A single value applies to reads and writes. Comma-separated
> -values may be specified for reads and writes. This option cannot be used
> -with the `prio` or `prioclass` options. For this option to be effective,
> +values may be specified for reads and writes. For this option to be effective,
> NCQ priority must be supported and enabled, and `direct=1' option must be
> used. fio must also be run as the root user.
> .TP
>
Looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
--
Damien Le Moal
Western Digital Research
