Re: [PATCH 5/5] t/zbd: Add -w option to ensure no open zone before write tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 13, 2021 at 03:09:03PM +0900, Shin'ichiro Kawasaki wrote:
> The commit b34eb155e4a6 ("t/zbd: Reset all zones before test when max
> open zones is specified") introduced -o max_open_zones option to the
> script t/zbd/test-zbd-support. It passes max_open_zones value to fio and
> resets all zones of the test target device before each test case run
> with write operation. This zone reset by the script ensures that no zone
> out of the IO range is in open status and the write operation do not
> exceed the max_open_zones limit.
> 
> On the other hand, since commit d2f442bc0bd5 ("ioengines: add
> get_max_open_zones zoned block device operation"), fio automatically
> fetches the max_open_zones value. So it is no longer required to pass
> the max_open_zones value from the script to fio. To simplify the script
> usage, introduce -w option which does not require max_open_zones value.
> This option just resets zones before test cases with write operation.
> 
> Of note is that fio itself resets the zones exceeding max_open_zones
> limit since the commit 954217b90191 ("zbd: Initialize open zones list
> referring zone status at fio start"), but it just resets zones within
> the fio IO range. Still zone reset by the test script is required for
> zones out of IO range. Zone reset out of IO range by fio is not
> implemented since it may cause unexpected data erasure.
> 
> Suggested-by: Niklas Cassel <niklas.cassel@xxxxxxx>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> ---

Reviewed-by: Niklas Cassel <niklas.cassel@xxxxxxx>



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux