Re: [PATCH 1/5] zbd: Remove cast to unsigned long long for printf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 13, 2021 at 03:08:59PM +0900, Shin'ichiro Kawasaki wrote:
> Many of the variables in zbd.c have type uint64_t. They are casted to
> unsigned long long and printed with printf %llu format to handle
> uint64_t types difference among architectures. This requires many
> lengthy casts to unsigned long long.
> 
> To simplify the code, remove the casts to unsigned long long. Some of
> the casts are simply unnecessary. To remove other casts, replace the
> printf format %llu with PRIu64 so that uint64_t type difference among
> architectures is handled accordingly.
> 
> Fio build pass of this change was confirmed with 32bit ARM cross
> compiler and 64bit x86 compiler.
> 
> Suggested-by: Niklas Cassel <niklas.cassel@xxxxxxx>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> ---

Reviewed-by: Niklas Cassel <niklas.cassel@xxxxxxx>



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux