On 9/8/21 9:07 AM, Andrzej Jakowski wrote:
> This patch allows to flexibly assign IO threads to fileset. When
> you specify:
>
> t/io_uring -n 5 /dev/dev1 dev/dev2
>
> First file/device will get 3 IO threads and second file/device
> remaining 2 IO threads. When there is more files then IO threads,
> IO thread may get assigned multiple files/devices.
Not to nit pick, but:
> @@ -620,37 +621,57 @@ int main(int argc, char *argv[])
>
> j = 0;
> i = optind;
> + nfiles = argc - i;
> + if (!nfiles) {
> + printf("no files specified\n");
> + return 1;
> + }
I think this looks correct now, do we want to call usage() here?
Seems common practice for any kind of invocation error.
usage() should probably exit() with non-zero though, in general.
--
Jens Axboe
