On Aug 05, 2021 / 19:04, Dmitry Fomichev wrote: > On Thu, 2021-08-05 at 12:28 +0900, Shin'ichiro Kawasaki wrote: > > Trim workload is currently not supported for zonemode=zbd. This patch > > series > > enables it by resetting zones for trim I/Os. This allows fio to measure > > performance of zoned block devices using more realistic workloads which > > mixes > > write and trim. > > > > The first patch prepares for trim support by modifying the helper > > function > > zbd_find_zone(). The second patch adds zone reset for trim. The third > > patch > > enables trim workload for libzbc I/O engine. The fourth patch adds a > > test > > case that exercises trim operation with zonemode=zbd. > > The fourth patch updates the HOWTO file to describe the added > functionality. The fifth patch adds a test case that exercises trim > operation with zonemode=zbd. Thanks, I forgot to update this part. > > > > > Changes from v1: > > * Separated HOWTO/man changes from 2nd patch as 4th patch > > * Reflected various comments on the list > > > > Shin'ichiro Kawasaki (5): > > zbd: Add min_bytes argument to zbd_find_zone() > > zbd: Support zone reset by trim > > engines/libzbc: Enable trim for libzbc I/O engine > > HOWTO/man: Describe trim support by zone reset for zoned devices > > t/zbd: Add test #58 to test zone reset by trim workload > > > > HOWTO | 9 +++++ > > engines/libzbc.c | 13 ++++--- > > fio.1 | 4 +- > > io_u.c | 9 +++++ > > t/zbd/test-zbd-support | 26 +++++++++++++ > > zbd.c | 85 +++++++++++++++++++++++++++++++++++------- > > zbd.h | 2 + > > 7 files changed, 127 insertions(+), 21 deletions(-) > > > > This series looks good to me. The suggested wording changes in the > commit message and and in patch 4 are nits. > > Reviewed-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx> Thank you. I will send out v3 soon, reflecting your comments on the patch 4. Also, I'll add your Reviewed-by tags. -- Best Regards, Shin'ichiro Kawasaki
