Re: [PATCH 1/2] Add missing documentation for job_max_open_zones.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Ankit,

On Aug 03, 2021 / 15:58, Ankit Kumar wrote:
> ---
>  HOWTO | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/HOWTO b/HOWTO
> index 59c7f1f..d4e620d 100644
> --- a/HOWTO
> +++ b/HOWTO
> @@ -1055,6 +1055,11 @@ Target file/device
>  	number of open zones is defined as the number of zones to which write
>  	commands are issued.
>  
> +.. option:: job_max_open_zones=int
> +
> +	Limit on the number of simultaneously opened zones per single
> +	thread/process.
> +

This change looks good to me, but I think the commit message title can be
improved. "HOWTO: " prefix will help to identify the change target file. Also,
I suggest to remove the period in the title. As far as I know, all fio commits
do not have period in their commit message titles.

>  .. option:: zone_reset_threshold=float
>  
>  	A number between zero and one that indicates the ratio of logical
> -- 
> 1.8.3.1
> 

-- 
Best Regards,
Shin'ichiro Kawasaki




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux