Re: [PATCH 1/3] zbd: create a local zbdi variable for f->zbd_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 24, 2021 at 11:09:11PM +0300, Alexey Dobriyan wrote:
> On Thu, Jun 24, 2021 at 05:23:07PM +0000, Niklas Cassel wrote:
> > +	struct zoned_block_device_info *zbdi = f->zbd_info;
> 
> It is unrelated to the patch. But! It is impossible to type
> "zoned_block_device_info" without autocompletion.
> 
> Can it be renamed just to 
> 
> 	struct zbd * const zbd = f->zbd_info;
> 
> "info" is kind of information free word, too.

Hello Alexey!


Like you say, such a change seems unrelated to this patch.

Feel free to send out a patch that renames struct zoned_block_device_info
to something else.
(Although, you might want to wait until this series has been merged.)

If we were to rename the struct, I personally think that "struct zbd_info"
is a better name than just "struct zbd".


Kind regards,
Niklas



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux