Re: [PATCH 1/4] zbd: disallow pipes for zonemode=zbd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021/06/04 21:18, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@xxxxxxx>
> 
> zoned block device support in fio cannot handle pipes,
> so simply reject them and give a clear error message.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
> ---
>  zbd.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/zbd.c b/zbd.c
> index 5d9e331a..60325d28 100644
> --- a/zbd.c
> +++ b/zbd.c
> @@ -32,6 +32,11 @@ int zbd_get_zoned_model(struct thread_data *td, struct fio_file *f,
>  {
>  	int ret;
>  
> +	if (f->filetype == FIO_TYPE_PIPE) {
> +		log_err("zonemode=zbd does not support pipes\n");
> +		return -EINVAL;
> +	}
> +
>  	if (td->io_ops && td->io_ops->get_zoned_model)
>  		ret = td->io_ops->get_zoned_model(td, f, model);
>  	else
> 

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx>

-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux