Re: [PATCH] configure: fix check_min_lib_version() eval

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/6/21 10:23 AM, Stefan Hajnoczi wrote:
> The following shell statement:
> 
>   if eval "echo \$$_feature" = "yes" ; then
> 
> executes:
> 
>   echo $... = "yes"
> 
> It does not actually compare the variable named by $_feature to the
> string "yes".
> 
> Add the missing "test" call so the comparison happens as intended and
> wrap the eval so it doesn't include the = "yes".

Applied, thanks.

-- 
Jens Axboe




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux