Re: [PATCH 1/4] parse: simplify parse_is_percent()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/22/21 9:37 AM, Alexey Dobriyan wrote:
> On Mon, Feb 22, 2021 at 07:36:42AM -0700, Jens Axboe wrote:
>> On 2/22/21 6:20 AM, Alexey Dobriyan wrote:
>>> Check "unsigned long long val <= -1ULL" is tautologically true
>>> because of how value conversions work.
>>
>> Thanks, applied this and the other 3 patches. Note for future
>> patch series you should use git send-email and provide a small cover
>> letter for the series. Also avoids typos like 2/5 for patch 2, and
>> it gives the reviewer a sense of the whole series.
> 
> Oh well, still can't get used to bulk emailing.
> 
> These patches are independent in fact.
> There is textual dependency between parse_is_percent() and main 'z'
> suffix patch.
> 
> And the rest was found while reading code for 'z' suffix.

Even if they are independent, it's easier to organize if you send
it out as a series :-)

-- 
Jens Axboe




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux