Re: [PATCH v4 2/2] Calculate min_rate with the consideration of thinktime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 20 Jan 2021 at 10:44, Hongwei Qin <glqinhongwei@xxxxxxxxx> wrote:
>
> This patch updates the compare time if handle_thinktime
> sleeps or spin.
>
> Signed-off-by: Hongwei Qin <glqinhongwei@xxxxxxxxx>
> ---
>  backend.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/backend.c b/backend.c
> index 874e193..f2efddd 100644
> --- a/backend.c
> +++ b/backend.c
> @@ -858,7 +858,8 @@ static long long usec_for_io(struct thread_data *td, enum fio_ddir ddir)
>         return 0;
>  }
>
> -static void handle_thinktime(struct thread_data *td, enum fio_ddir ddir)
> +static void handle_thinktime(struct thread_data *td, enum fio_ddir ddir,
> +                            struct timespec *time)
>  {
>         unsigned long long b;
>         uint64_t total;
> @@ -898,6 +899,9 @@ static void handle_thinktime(struct thread_data *td, enum fio_ddir ddir)
>                 /* adjust for rate_process=poisson */
>                 td->last_usec[ddir] += total;
>         }
> +
> +       if (time && should_check_rate(td))
> +               fio_gettime(time, NULL);
>  }
>
>  /*
> @@ -1078,7 +1082,7 @@ reap:
>                         break;
>
>                 if (ddir_rw(ddir) && td->o.thinktime)
> -                       handle_thinktime(td, ddir);
> +                       handle_thinktime(td, ddir, &comp_time);
>
>                 if (!ddir_rw_sum(td->bytes_done) &&
>                     !td_ioengine_flagged(td, FIO_NOIO))
> --
> 1.8.3.1
>

LGTM:
Signed-off-by: Sitsofe Wheeler <sitsofe@xxxxxxxxx>

-- 
Sitsofe



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux