Re: [PATCH v3 21/38] zbd: avoid failing assertion in zbd_convert_to_open_zone()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 07, 2021 / 06:57, Dmitry Fomichev wrote:
> The test run against null_blk with the following command line -
> 
> t/zbd/run-tests-against-nullb -l -q -s 12 -t 51 -n 100
> 
> stops with a failure and the message below can be seen in the test log:
> 
> fio: zbd.c:1110: zbd_convert_to_open_zone: Assertion `open_zone_idx < f->zbd_info->num_open_zones' failed.
> 
> This assertion fails because pick_random_zone_idx() function returns
> index 0 if no zones are currently open. In this case, open_zone_idx and
> f->zbd_info->num_open_zones are both zero. Since this situation is
> normal, simply modify the assert statement to avoid failing.
> 
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>

-- 
Best Regards,
Shin'ichiro Kawasaki



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux