Hi Sitsofe, > > At this point wouldn't it be better to update the help to reflect the > code rather than the other way around? > Consider this configuration: [global] thread kb_base=1000 direct=1 size=28GiB group_reporting io_size=64KiB ioengine=libaio iodepth=32 bs=4096 filename=/dev/qblkdev [fio_randwrite] rw=randwrite thinktime_blocks=4 thinktime=1s I write this job file to simulate a data server that periodically writes back a certain amount of data (In this case,16KiB per second). Note that we cannot use the rate_iops here because it will send 1 request per 250ms. If we keep the code as it is, the job will finish immediately after the test starts. And this is usually not what the user wants. Or, should we introduce a new parameter to distinguish between "think after finish" and "think after issue"? Regards, Hongwei On Sun, Jan 17, 2021 at 5:54 PM HongweiQin <glqinhongwei@xxxxxxxxx> wrote: > > According to the manual, the thinktime_blocks controls how many blocks to issue (instead of complete) before waiting. > > Signed-off-by: HongweiQin <glqinhongwei@xxxxxxxxx> > --- > backend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/backend.c b/backend.c > index e20a2e0..c85669c 100644 > --- a/backend.c > +++ b/backend.c > @@ -864,7 +864,7 @@ static void handle_thinktime(struct thread_data *td, enum fio_ddir ddir) > uint64_t total; > int left; > > - b = ddir_rw_sum(td->io_blocks); > + b = ddir_rw_sum(td->io_issues); > if (b % td->o.thinktime_blocks) > return; > > -- > 1.8.3.1 >
