On 11/6/20 11:41 AM, Eric Sandeen wrote:
> Builds with --dynamic-libengines are currently broken, because the rule
> to build the libraries was moved out of the template that creates them:
>
> make: *** No rule to make target 'engines/libpmem.so', needed by 'all'. Stop.
> make: *** Waiting for unfinished jobs....
>
> Fix this by moving the rule back into the template, calling the template
> to create rules only after FIO_CFLAGS has been incorporated into CFLAGS,
> and using CFLAGS + -fPIC in that rule rather than FIO_CFLAGS.
>
> Fixes: 8a2cf08d29ac ("Makefile: introduce FIO_CFLAGS")
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>
> I think this is correct, but I would appreciate a review from Sitsofe.
NAK
breaks built-in engines. Argh.
