Re: [PATCH] fio: fix dynamic engines soname definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Did this one get overlooked? CC'ing Jens...


On Mon, 5 Oct 2020 at 18:17, Yigal Korman <ykorman@xxxxxxxxx> wrote:
>
> The SONAME of the engines should not match the name of the dependent
> library. Otherwise it confuses the dynamic loader into thinking the
> dependency is already resolved.
>
> Prefixing the name with fio make more sense here.
>
> Signed-off-by: Yigal Korman <ykorman@xxxxxxxxx>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 5ed8a808..48788f24 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -569,7 +569,7 @@ endif
>
>  ifdef CONFIG_DYNAMIC_ENGINES
>  engines/lib$(1).so: $$($(1)_OBJS)
> -       $$(QUIET_LINK)$(CC) -shared -rdynamic -fPIC -Wl,-soname,lib$(1).so.1 $$($(1)_LIBS) -o $$@ $$<
> +       $$(QUIET_LINK)$(CC) -shared -rdynamic -fPIC -Wl,-soname,fio-$(1).so.1 $$($(1)_LIBS) -o $$@ $$<
>  endif
>
>  clean: FORCE
> --
> 2.17.1
>


--
Sitsofe | http://sucs.org/~sits/



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux