> -----Original Message----- > From: fio-owner@xxxxxxxxxxxxxxx <fio-owner@xxxxxxxxxxxxxxx> On Behalf > Of Andreas Herrmann > Sent: Friday, August 28, 2020 5:05 AM > To: Jens Axboe <axboe@xxxxxxxxx> > Cc: fio@xxxxxxxxxxxxxxx > Subject: [PATCH 1/2] thread_options: Add cgroup_use_bfq > ... > @@ -593,11 +594,13 @@ struct thread_options_pack { > uint8_t profile[FIO_TOP_STR_MAX]; > > /* > - * blkio cgroup support > + * (blk)io cgroup support > */ > uint8_t cgroup[FIO_TOP_STR_MAX]; > uint32_t cgroup_weight; > uint32_t cgroup_nodelete; > + uint32_t cgroup_use_bfq; > + uint32_t padding; /* remove when possible to maintain alignment */ > > uint32_t uid; > uint32_t gid; Since the structure already has three pad fields: uint32_t pad; uint64_t size; ... uint32_t pad2; uint64_t rand_seed; ... uint32_t pad3; fio_fp64_t percentile_list[FIO_IO_U_LIST_MAX_LEN]; pad4 would seem like the natural name for another padding field, and the comment doesn't seem necessary.