> -----Original Message-----
> From: Sitsofe Wheeler <sitsofe@xxxxxxxxx>
> Sent: Sunday, August 16, 2020 4:48 PM
> To: Tomohiro Kusumi <kusumi.tomohiro@xxxxxxxxx>
> Cc: Damien Le Moal <Damien.LeMoal@xxxxxxx>; Dmitry Fomichev
> <Dmitry.Fomichev@xxxxxxx>; fio@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 2/4] configure: check if pkg-config is installed
>
> On Sat, 15 Aug 2020 at 23:05, Tomohiro Kusumi
> <kusumi.tomohiro@xxxxxxxxx> wrote:
> >
> > 2020年8月5日(水) 16:06 Damien Le Moal <Damien.LeMoal@xxxxxxx>:
> > >
> > > On 2020/08/04 10:38, Dmitry Fomichev wrote:
> > > > A few libraries need to be newer than a specific version in order to be
> > > > supported by fio and pkg-config utility is used to verify the versions
> > > > of the installed libraries. Since this step may fail because pkg-config
> > > > is not installed, verify pkg-config presence and warn the user if it
> > > > could not be found.
> > > >
> > > > To avoid code duplication, add a common helper function to perform
> > > > these checks.
> >
> > This line
> > "if test ${!feature} = "yes" ; then"
> > seems to have broken compilation on some BSD's.
> >
> > [root@localhost fio]# uname
> > NetBSD
> > [root@localhost fio]# gmake clean && gmake
> > FIO_VERSION = fio-3.21-56-g0ce7e
> > Running configure ...
> > ./configure: 144: Syntax error: Bad substitution
> > Makefile:19: config-host.mak: No such file or directory
> > gmake: *** [Makefile:10: config-host.mak] Error 2
>
> Looks like a few bashisms have snuck into configure (shellcheck warns
> about some other stuff). I think NetBSD's sh is ash...
>
Indeed. I just sent the fix for this problem.
Tomohiro,
Would you be able to test the new patch?
Thank you,
Dmitry
> --
> Sitsofe | http://sucs.org/~sits/
