Re: [PATCH 3/6] t/zbd: Improve usage message of test-zbd-support script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-08-13 at 13:57 +0900, Shin'ichiro Kawasaki wrote:
> The usage message of t/zbd/test-zbd-support does not explain meaning of
> each option. Elaborate meaning of the options.
> 
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>


Looks good.
Reviewed-by: Dmitry Fomichev: <dmitry.fomichev@xxxxxxx>

> ---
>  t/zbd/test-zbd-support | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support
> index 139495d3..9e398cab 100755
> --- a/t/zbd/test-zbd-support
> +++ b/t/zbd/test-zbd-support
> @@ -5,7 +5,15 @@
>  # This file is released under the GPL.
>  
>  usage() {
> -    echo "Usage: $(basename "$0") [-d] [-e] [-l] [-r] [-v] [-t <test>] [-z] <SMR drive device node>"
> +	echo "Usage: $(basename "$0") [OPTIONS] <test target device file>"
> +	echo "Options:"
> +	echo -e "\t-d Run fio with valgrind using DRD tool"
> +	echo -e "\t-e Run fio with valgrind using helgrind tool"
> +	echo -e "\t-v Run fio with valgrind --read-var-info option"
> +	echo -e "\t-l Test with libzbc ioengine"
> +	echo -e "\t-r Reset all zones before test start"
> +	echo -e "\t-t <test #> Run only a single test case with specified number"
> +	echo -e "\t-z Run fio with debug=zbd option"
>  }
>  
>  max() {




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux