Re: [PATCH] zbd: don't read past the WP on a read only workload with verify

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Aug 13, 2020 / 17:01, Niklas Cassel wrote:
> From: Aravind Ramesh <aravind.ramesh@xxxxxxx>
> 
> When running a read only workload with verify option enabled,
> fio continues to read beyond the write pointer, and thus
> reads a deallocated block, which contains data of a predefined
> pattern, thus causing the verify to fail.
> 
> Thus, we cannot simply jump to accept for a read only workload
> with verify option enabled, we must let the regular flow of
> execution to continue, so that the check if offset > wp is
> performed, so that we will return the address to a new zone,
> rather than an address that is past the wp.
> 
> Reading past the wp is not a recent bug, it is possible to
> reproduce this bug even before zone capacity was introduced.
> 
> However, with the introduction of zone capacity, filling a
> zone now only writes up to zone capacity of a zone, making
> it much easier to reproduce this bug.
> 
> Signed-off-by: Aravind Ramesh <aravind.ramesh@xxxxxxx>
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>

-- 
Best Regards,
Shin'ichiro Kawasaki



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux