On 2020/04/13 17:33, Shin'ichiro Kawasaki wrote:
> When sg_inq command is executed to check if it can provide maximum open
> zones, the command's standard output was not discarded and caused
> unexpected script behavior. Fix it discarding the standard output.
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> ---
> t/zbd/functions | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/t/zbd/functions b/t/zbd/functions
> index 35087b15..5bffad6e 100644
> --- a/t/zbd/functions
> +++ b/t/zbd/functions
> @@ -43,7 +43,8 @@ max_open_zones() {
> local dev=$1
>
> if [ -n "${sg_inq}" ] && [ ! -n "${use_libzbc}" ]; then
> - if ! ${sg_inq} -e --page=0xB6 --len=20 --hex "$dev" 2> /dev/null; then
> + if ! ${sg_inq} -e --page=0xB6 --len=20 --hex "$dev" \
> + > /dev/null 2>&1; then
> # Non scsi device such as null_blk can not return max open zones.
> # Use default value.
> echo 128
>
Looks good.
Reviewed-by: Damien Le Moal <damien.lemoaal@xxxxxxx>
--
Damien Le Moal
Western Digital Research
