On 3/27/20 1:06 PM, Alexey Dobriyan wrote: > On Fri, Mar 27, 2020 at 02:26:41PM +0000, Keith Busch wrote: >> On 3/27/20 8:25 AM, Keith Busch wrote: >>> If you're really going to do it, though, I would recommend not using >>> NVME_IOCTL_SUBMIT_IO, and instead always use the more flexible >>> NVME_IOCTL_SUBMIT_IO. >> >> Err, that second ioctl should have said "NVME_IOCTL_IO_CMD". > Why? NVME_IOCTL_SUBMIT_IO is so much simpler. > Except trim, when there is no choice. Or flush, append, and any other IO command that's not read or write. The kernel should deprecate that ioctl, there's no reason to maintain both of these ioctls when one can handle everything.
