On 12/10/19 4:32 PM, Sitsofe Wheeler wrote:
On Tue, 10 Dec 2019 at 17:56, <vincentfu@xxxxxxxxx> wrote:
From: Vincent Fu <vincent.fu@xxxxxxx>
Jens, please consider this series of patches related to testing.
The patches improve t/run-fio-tests.py in various ways, most prominently
adding support for Windows and macOS.
Also included are travis and appveyor patches that add run-fio-tests.py
as a step. Currently both the travis and appveyor build processes
complete in less than four minutes. Adding run-fio-tests.py increases
this to about 20 minutes for travis and 14 minutes for appveyor.
In general I think this work is fantastic and much needed (you can
search through the fio commit logs using "git log --grep 'size='" to
find jobs files that have caused issues in the past and may be worth
turning into tests at some point). However, I think making the builds
so slow may be a disadvantage rather than a benefit. I agree with
nearly all the patch set bar running this by default with
travis/appveyor...
Many thanks for the feedback, Sitsofe. I agree that the build times are
uncomfortably long, but since I had done the work I thought I would
offer the patches to Jens.
Jens, what do you think? Would you like me to re-send the patch series
without the appveyor and travis changes?
