Re: [PATCH] zbd: Fix job zone size initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019/08/30 10:52, Jens Axboe wrote:
> On 8/29/19 7:45 PM, Damien Le Moal wrote:
>> For a job accessing a zoned block device, the zone size is automatically
>> initialized to the device zone size. However, since zone information for
>> a zoned block device is parsed once only for the first job
>> initialization of a multi job workload, only the first job has its
>> zonesize option intialized, causing problem if the zoneskip option is
>> also used (assert exit).
>>
>> Fix this by always initializing a job zonesize option using the job
>> file zbd information when verifying the job ZBD related sizes and
>> offsets.
> 
> Applied, thanks.
> 

Jens,

Thanks. But I just realized that the check is incomplete. If each job specifies
"zonesize=X" instead of not specifying a zone size and relying on the automatic
initialization from the device zone size, then "X == device zone size" must be
checked too.

Sending an additional patch for this. My apologies for the churn.

Thank you.

-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux