On 8/2/19 9:32 AM, Richard W.M. Jones wrote: > diff --git a/engines/nbd.c b/engines/nbd.c > new file mode 100644 > index 00000000..399da5f3 > --- /dev/null > +++ b/engines/nbd.c > @@ -0,0 +1,368 @@ > +/* > + * NBD engine > + * > + * IO engine that talks to an NBD server. > + * > + * Copyright (C) 2019 Red Hat Inc. > + * Written by Richard W.M. Jones <rjones@xxxxxxxxxx> > + * > + */ > + > +#include <stdio.h> > +#include <stdlib.h> > +#include <stdint.h> > +#include <errno.h> > + > +#include <libnbd.h> > + > +#include "../fio.h" > +#include "../optgroup.h" > + > +/* Actually this differs across servers, but for nbdkit ... */ > +#define NBD_MAX_REQUEST_SIZE (64 * 1024 * 1024) > + > +/* Storage for the NBD handle. */ > +struct nbd_data { > + struct nbd_handle *nbd; > + int debug; Here (and lots of other places) you have a mix of tabs and spaces. Please make them all tab based. -- Jens Axboe