On Thu, Apr 25, 2019 at 10:10:40AM -0600, Jens Axboe wrote: > On 4/25/19 9:52 AM, Richard W.M. Jones wrote: > > It seems like these two lines might be in the wrong order? (and the > > same thing later in the file too) > > > > https://github.com/axboe/fio/blob/afc22c98609ee80a99fbed24231181bdab2bc659/optgroup.h#L65-L66 > > They are, that's a bug. Thanks for letting me know, I've fixed it up. Thanks. I think also these lines later in the same file -- although not technically a bug -- should also be swapped around: FIO_OPT_G_INVALID = (1ULL << __FIO_OPT_G_NR), FIO_OPT_G_ISCSI = (1ULL << __FIO_OPT_G_ISCSI), Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/
