Phillip,
On 2019/04/24 14:48, phillip.a.chen@xxxxxxxxxxx wrote:
> From: Phillip Chen <phillip.a.chen@xxxxxxxxxxx>
>
> Signed-off-by: Phillip Chen <phillip.a.chen@xxxxxxxxxxx>
> Initialize conventional zone write pointers to full so
> zbd_find_zone will accept conventional zones when searching
> around a randomly chosen empty zone.
A patch format is generally:
component: title (what is the patch)
description
Signed-of-by: ...
So in your case, the patch should probably be something like:
zbd: Fix zone selection
Initialize conventional zone write pointers to full so
zbd_find_zone() will accept conventional zones under random reads/write workloads.
Signed-off-by: Phillip Chen <phillip.a.chen@xxxxxxxxxxx>
>
> ---
> zbd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/zbd.c b/zbd.c
> index 2da742b7..616c3e0e 100644
> --- a/zbd.c
> +++ b/zbd.c
> @@ -418,8 +418,6 @@ static int parse_zone_info(struct thread_data *td, struct fio_file *f)
> p->start = z->start << 9;
> switch (z->cond) {
> case BLK_ZONE_COND_NOT_WP:
> - p->wp = p->start;
> - break;
> case BLK_ZONE_COND_FULL:
> p->wp = p->start + zone_size;
> break;
>
Other than that, the code seems fine, so:
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx>
--
Damien Le Moal
Western Digital Research
