Hi Rebecca, On Wed, 24 Apr 2019 at 00:44, Rebecca Cran <rebecca@xxxxxxxxxxxx> wrote: > > Since I've been doing a bit of work on Solaris 11.4 x86_64 recently, I > decided to see if fio works on it. > > It turns out it fails to build (using gcc 7.3.0): > > > bcran@solaris:~/workspace/fio$ gmake > CC stat.o > In file included from os/os.h:46:0, > from thread_options.h:5, > from fio.h:18, > from stat.c:7: > stat.c: In function 'show_thread_status_normal': > os/os-solaris.h:46:33: error: too many arguments to function 'ctime_r' > #define os_ctime_r(x, y, z) ctime_r((x), (y), (z)) > ^ > stat.c:804:2: note: in expansion of macro 'os_ctime_r' > os_ctime_r((const time_t *) &time_p, time_buf, sizeof(time_buf)); > ^~~~~~~~~~ > In file included from /usr/include/sys/time.h:447:0, > from /usr/include/sys/select.h:27, > from /usr/include/sys/types.h:665, > from /usr/include/string.h:15, > from stat.c:2: > /usr/include/time.h:265:14: note: declared here > extern char *ctime_r(const time_t *, char *); > ^~~~~~~ > In file included from os/os.h:46:0, > from thread_options.h:5, > from fio.h:18, > from stat.c:7: > stat.c: In function '__show_run_stats': > os/os-solaris.h:46:33: error: too many arguments to function 'ctime_r' > #define os_ctime_r(x, y, z) ctime_r((x), (y), (z)) > ^ > stat.c:1969:3: note: in expansion of macro 'os_ctime_r' > os_ctime_r(&tv_sec, time_buf, sizeof(time_buf)); > ^~~~~~~~~~ > In file included from /usr/include/sys/time.h:447:0, > from /usr/include/sys/select.h:27, > from /usr/include/sys/types.h:665, > from /usr/include/string.h:15, > from stat.c:2: > /usr/include/time.h:265:14: note: declared here > extern char *ctime_r(const time_t *, char *); > ^~~~~~~ > gmake: *** [Makefile:369: stat.o] Error 1 > I think this is https://github.com/axboe/fio/issues/714 which I never got around to sending a patch for... -- Sitsofe | http://sucs.org/~sits/