On Fri, 8 Feb 2019 at 21:44, Jeff Furlong <jeff.furlong@xxxxxxx> wrote: > > Occasionally fio client/server with zlib enabled may report: > > fio: inflate error -5 > fio: failed decompressing log > fio: failed converting IO log > [snip] > > The way we tell that deflate() has no more output is by seeing that it did not fill the output buffer, leaving avail_out greater than zero. However suppose that deflate() has no more output, but just so happened to exactly fill the output buffer! avail_out is zero, and we can't tell that deflate() has done all it can. As far as we know, deflate() has more output for us. So we call it again. But now deflate() produces no output at all, and avail_out remains unchanged as CHUNK. That deflate() call wasn't able to do anything, either consume input or produce output, and so it returns Z_BUF_ERROR. (See, I told you I'd cover this later.) However this is not a problem at all. Now we finally have the desired indication that deflate() is really done, and so we drop out of the inner loop to provide more input to deflate()." Wow. Does this fix the bug you found from a few years back: https://www.spinics.net/lists/fio/msg05877.html ? -- Sitsofe | http://sucs.org/~sits/
