Re: [PATCH 1/2] eta: Avoid adjustements to a negative value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/26/18 12:42 AM, Damien Le Moal wrote:
> In the case of zonemode=strided job with both zone_size and zone_skip
> specified, thread_eta() calculates the upper bound of the number of
> zones that will be processed, including skipped bytes between zones
> (zone_skip). Adjusting bytes_total (i.e. total_io_size) by substracting
> this number of zones times the amount of skipped bytes can result in
> a negative value for bytes_total (a large number of bytes) when for
> example the job operates on an entire disk with a capacity that is not
> divisible exactly by zone_size+zone_skip or if the options --size is
> used to limit the I/O range. In such case, use the lower bound of the
> number of zones to obtain a better approximation of the job eta.
> 
> Additionnally, if --io_size was specified, bytes_total will indicate
> this exact value, so adjusting that value for zonemode != none is not
> necessary.

Applied 1-2, thanks Damien.

-- 
Jens Axboe




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux