On 7/10/18 9:32 AM, Bart Van Assche wrote:
> Hello Jens,
>
> In __fill_io_u_zone() I found the following code (see also commit 224b3093cc21
> ("Fix zoning issue with seq-io and randommap issue")):
>
> /*
> * Wrap from the beginning, if we exceed the file size
> */
> if (f->file_offset >= f->real_file_size)
> f->file_offset = f->real_file_size - f->file_offset;
>
> If f->file_offset > f->real_file_size then f->real_file_size - f->file_offset
> will be negative and hence the above assignment will store a negative number
> in f->file_offset. Is that what the above code is intended to do?
No, that looks wrong. But looking at the commit, it basically just moved
that code, so the issue predates that particular change.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
