RE: fio make warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Robert.  These old gcc versions are still inbox in many distros.  After reading BZ 59124 I see the hack of a fix to disable the warning is:


diff --git a/init.c b/init.c
index 353c99b..0fae65b 100644
--- a/init.c
+++ b/init.c
@@ -1043,7 +1043,7 @@ void td_fill_rand_seeds(struct thread_data *td)
        bool use64;

        if (td->o.allrand_repeatable) {
-               unsigned int i;
+               unsigned long i;

                for (i = 0; i < FIO_RAND_NR_OFFS; i++)
                        td->rand_seeds[i] = FIO_RANDSEED * td->thread_number


Works on gcc version 4.8.3 20140911.  But, doesn't seem we need the fix as it's a real gcc bug.

Regards,
Jeff

-----Original Message-----
From: Elliott, Robert (Persistent Memory) [mailto:elliott@xxxxxxx] 
Sent: Monday, June 18, 2018 12:52 PM
To: Jeff Furlong <jeff.furlong@xxxxxxx>; Sitsofe Wheeler <sitsofe@xxxxxxxxx>
Cc: fio@xxxxxxxxxxxxxxx
Subject: RE: fio make warning



> -----Original Message-----
> From: fio-owner@xxxxxxxxxxxxxxx [mailto:fio-owner@xxxxxxxxxxxxxxx] On 
> Behalf Of Jeff Furlong
> Sent: Friday, June 15, 2018 6:00 PM
> To: Sitsofe Wheeler <sitsofe@xxxxxxxxx>
> Cc: fio@xxxxxxxxxxxxxxx
> Subject: RE: fio make warning
> 
> Right, using the latest git.  I checked the latest releases and 
> fio-3.5 does not have the warning, but fio-3.6 introduces it.  I was 
> using gcc version 4.8.3 20140911.  I moved to gcc version 4.8.5 
> 20150623 on another kernel and I don't see the issue.  Odd how the 
> warning only happens with in between compiler versions and latest fio source.

gcc apparently had some bugs in that area four years ago:
	https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56273
	https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59124


��.n��������+%������w��{.n�������^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux