On 11/21/2017 07:09 PM, Jeff Furlong wrote: > Hi All, > Attached is a patch for adding a new significant figures parameter to > the normal output format. Somes when using large I/O sizes, the > hardcoded 4 sig figs does not truly represent the throughput, due to > rounding/truncating. So this parameter allows the value to be user > settable, without having to inspect json outputs (intended for machine > readable, not human readable). With this patch, the default behavior > is exactly as it is today, meaning the default sig_figs is 4. If a > user enables --sig_figs=5, then one extra digit will be displayed. > Please let me know of any bugs/issues. Thanks. Looks good to me, but sig_figs is sort-of a horrible name. Why not just call it 'significant_figures' instead? It's longer, but you know what it is. Your patch also seems somewhat mangled on white space. Care to resend with the name change, and in a cleaner version? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
