Right..
Sorry, I just reused the message right above which originates
42f1ee68ceec87fbbfdc4972c35d3cdf7c08d9f6 ("Improve informativeness
about directIO support or rather lackthereof on Solaris when errno is
set to ENOTTY").
I'll send v3.
2017-09-18 21:26 GMT+03:00 Jens Axboe <axboe@xxxxxxxxx>:
> On 09/18/2017 12:23 PM, kusumi.tomohiro@xxxxxxxxx wrote:
>> From: Tomohiro Kusumi <tkusumi@xxxxxxxxxx>
>>
>> This lets platforms without dio (e.g. OpenBSD) fail with an explicit
>> message, otherwise they fail without a clue about dio even with
>> --debug=all enabled.
>>
>> The message assumes platforms with O_DIRECT do not call this function
>> (and in fact they don't so it's not really a problem).
>>
>> Signed-off-by: Tomohiro Kusumi <tkusumi@xxxxxxxxxx>
>> ---
>> filesetup.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/filesetup.c b/filesetup.c
>> index b51ab35..9813873 100644
>> --- a/filesetup.c
>> +++ b/filesetup.c
>> @@ -1868,6 +1868,7 @@ int fio_set_directio(struct thread_data *td, struct fio_file *f)
>>
>> return 0;
>> #else
>> + log_err("fio: the file system does not seem to support direct IO\n");
>
> Should have caught this the first time, sorry... But that should say "the operating
> system", it's not a file system condition. I'd use something ala:
>
> fio: direct IO is not supported on this host operating system
>
> since it is possible that the OS does in fact support some variant of direct
> IO, but fio doesn't support it on that platform.
>
> --
> Jens Axboe
>
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
