Right. A check of memalign or page size can help. But the patch is no longer compatible with the latest git, given the recent revert. However, my concern for mem_align still remains. How does the current git use the mem_align parameter in fill_io_buffer(td, b, bs, bs)? Or is it completley handled elsewhere, namely init_io_u() and allocate_io_mem()? Regards, Jeff -----Original Message----- From: Sitsofe Wheeler [mailto:sitsofe@xxxxxxxxx] Sent: Monday, September 4, 2017 2:48 PM To: Jeff Furlong <jeff.furlong@xxxxxxx> Cc: fio@xxxxxxxxxxxxxxx Subject: Re: fio patch question on filesetup: align layout buffer Hi, On 30 August 2017 at 23:27, Jeff Furlong <jeff.furlong@xxxxxxx> wrote: > > I see the patch at http://git.kernel.dk/cgit/fio/commit/?id=8c43ba6259409244de64f0b1d388a029e38cf3e5 and just wondered if it is still compatible with: > > .. option:: iomem_align=int, mem_align=int > [...] > > For example, if we set mem_align to something larger than page_size or bs, what does fio_memalign use? And if we set mem_align to something between page_size and bs, what does fio_memalign use? Thanks. What do you think of https://github.com/sitsofe/fio/commit/8fed4ccc87e39144643b1e32caddd882e6197e58 ? -- Sitsofe | http://sucs.org/~sits/ ��.n��������+%������w��{.n�������^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
