On 08/04/2017 04:24 PM, sbates@xxxxxxxxxxxx wrote: > From: Stephen Bates <sbates@xxxxxxxxxxxx> > > By default file backed memory mappings are unlink()'ed after use. This > patch keeps the files if they already existed. We don't check for > errors on access() since we will catch them on the open(). > > Discovered this when doing p2pmem testing and fio kept deleting the > /dev/p2pmem0 files... > > Changes since v1 > Altered based on feedback from Jens to avoid using an option and > test for file existance instead. This gets closer, but it doesn't make sense to use a new member in the options structure for this. It's not an option, and as such it's a bad fit. Additionally, options should always have a counter part in the _packed version of the structure, and be converted as well, for the onwire protocol. I changed this to just use a flag in the thread_data instead: http://git.kernel.dk/cgit/fio/commit/?id=f9cfc7d44a80638f81810416385136c35ad34658 -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
