Re: [PATCH v2] pvsync2: Add hipri_probability option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/27/2017 10:44 AM, sbates@xxxxxxxxxxxx wrote:
> From: Stephen Bates <sbates@xxxxxxxxxxxx>
> 
> Allow the user to set the probability of a pvsync2 IO being high
> priority. Add a new option for the pvsync2 engine called
> --hipri_probability will takes values in the range (0, 100) and use
> that as a probability for setting RWF_HIPRI. The default for this
> option is 100 so exisiting users of --hirpi are unaffected by
> default.

Sorry to keep nit picking on this, but the reason I suggested
_percentage instead of _probability is that the former is in
the 0..100 range whereas the latter I would assume would be in
the 0..1 range. Since you've implemented it as a percentage,
and since we have other options like that, I think we should
make it hipri_percentage instead.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux