Re: [PATCH] pvsync2: Make hipri option probabilistic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/26/2017 08:20 PM, Stephen  Bates wrote:
> 
>> You are potentially breaking existing scripts with this change. If
>> someone currently has:
> 
>> hipri=1
> 
>> in their job file, it'll work fine. After this change, it'll be 1%
>> polled IO.
> 
> Fair point. How about I make it a float and use values between 0 and
> 1? That way existing scripts will continue to work.

That's kind of horrible from a usability point of view. Other percentage
options take 0..100. Since it's just an IO engine option, just add a
hipri_percentage or something option instead, which takes 0..100 as the
input.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux