Re: The commit 'filesetup: add native fallocate' breaks on Cygwin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/25/2017 1:16 AM, Tomohiro Kusumi wrote:
It seems the recent commit 2c3e17be ('filesetup: add native
fallocate') breaks on Cygwin.
It works on FreeBSD by the way.

I see the problem: FIO_FALLOCATE_NONE has a value of 1, so in fallocate_file the 0 which is produced for platforms like Windows that don't support fallocate fall through to the default case, which asserts. I'm not sure if we want to renumber the fio_fallocate_mode enum to start at 0?

By the way the breakage is on Windows in general: fio no longer uses Cygwin.

--
Rebecca
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux