Re: [PATCH] lib/ffz: remove dead store

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/26/2017 11:17 PM, Sitsofe Wheeler wrote:
> On 8 June 2017 at 00:53, Daniel Verkamp <daniel.verkamp@xxxxxxxxx> wrote:
>> 'word' is written in the last 'if' block but never read again.
>>
>> This is harmless, but scan-build (clang-analyzer) flags it as a warning.
>>
>> Signed-off-by: Daniel Verkamp <daniel.verkamp@xxxxxxxxx>
>> ---
>>  lib/ffz.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/lib/ffz.h b/lib/ffz.h
>> index e2c1b8e..b98dad6 100644
>> --- a/lib/ffz.h
>> +++ b/lib/ffz.h
>> @@ -28,7 +28,6 @@ static inline int ffs64(uint64_t word)
>>                 r += 2;
>>         }
>>         if (!(word & 1)) {
>> -               word >>= 1;
>>                 r += 1;
>>         }
>>
>> --
>> 2.9.4
> 
> Any thoughts on this one Jens (just checking it didn't slip through the net)?

It did, thanks for bringing it to my attention - applied, thanks Daniel.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux