On 05/01/2017 02:54 PM, Tomohiro Kusumi wrote: > Hi > > 2017-05-01 23:44 GMT+03:00 Jens Axboe <axboe@xxxxxxxxx>: >> On Mon, May 01 2017, kusumi.tomohiro@xxxxxxxxx wrote: >>> From: Tomohiro Kusumi <tkusumi@xxxxxxxxxx> >>> >>> fio on NetBSD may have CONFIG_POSIX_FALLOCATE configuration enabled >>> since posix_fallocate(3) compiles (at least on recent versions), >>> but this is actually not supported on UFS as mentioned in below wiki >>> and fio result. >>> >>> https://wiki.netbsd.org/projects/project/ffs-fallocate/ >>>> This functionality is not currently implemented for FFS; >>> >>> compile_prog() during ./configure fails to catch this as it doesn't >>> run the test code after compilation (and it needs to use a valid fd >>> in order to do runtime test). >>> >>> This commit simply disables CONFIG_POSIX_FALLOCATE on NetBSD regardless >>> of compilation result on ./configure. It doesn't check the fs type, >>> but it should be enough provided that UFS is the fs used by majority >>> of users and there's also no real alternative for disk fs. >> >> I'd much rather we just avoid it if we get EOPNOTSUPP at runtime. That >> way we don't have to change anything later on, when/if NetBSD does get >> support for fallocate. > > Yes, so the next one 2/11 actually mostly reverts this, and replace it > with runtime check, so that it works not only with this specific > NetBSD/UFS case, but also for e.g. Linux fs (something other than > ext4, XFS, etc). > I wasn't sure if runtime check (execute $TMPE) is preferred. Let's just drop 1/11 then, and have the first patch cover the runtime of it. But don't do that from configure. Whatever fs is hosting configure is less interesting. Maybe that doesn't support fallocate, but whatever you end up running on does. Or vice versa. > Any how, I'll resend the 1,2,3,4,11 with --cover-letter as you commented. Thanks! -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
