On Mon, Feb 13 2017, kusumi.tomohiro@xxxxxxxxx wrote:
> From: Tomohiro Kusumi <tkusumi@xxxxxxxxxx>
>
> to the destination file pointer.
> The ones in dup_files() doesn't seem to require locking from
> the way it's been called.
>
> Signed-off-by: Tomohiro Kusumi <tkusumi@xxxxxxxxxx>
> ---
> filesetup.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/filesetup.c b/filesetup.c
> index 3fa8b32..7a67fe6 100644
> --- a/filesetup.c
> +++ b/filesetup.c
> @@ -501,9 +501,11 @@ int file_lookup_open(struct fio_file *f, int flags)
> if (__f) {
> dprint(FD_FILE, "found file in hash %s\n", f->file_name);
> /*
> - * racy, need the __f->lock locked
> + * get __f->lock while it gets copied to f.
> */
> + fio_mutex_down(__f->lock);
> f->lock = __f->lock;
> + fio_mutex_up(__f->lock);
> from_hash = 1;
What if the file lock mode is FILE_LOCK_READWRITE?
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
